feat: configurable vibration amplitude on api >= 26#2175
Open
wzrayyy wants to merge 4 commits intoHeliBorg:mainfrom
Open
feat: configurable vibration amplitude on api >= 26#2175wzrayyy wants to merge 4 commits intoHeliBorg:mainfrom
wzrayyy wants to merge 4 commits intoHeliBorg:mainfrom
Conversation
Author
|
Closes #1791 |
eranl
reviewed
Dec 10, 2025
app/src/main/java/helium314/keyboard/latin/settings/Settings.java
Outdated
Show resolved
Hide resolved
app/src/main/java/helium314/keyboard/latin/settings/Settings.java
Outdated
Show resolved
Hide resolved
app/src/main/java/helium314/keyboard/settings/screens/PreferencesScreen.kt
Outdated
Show resolved
Hide resolved
Author
|
Thanks, done |
eranl
reviewed
Dec 10, 2025
app/src/main/java/helium314/keyboard/latin/AudioAndHapticFeedbackManager.java
Outdated
Show resolved
Hide resolved
eranl
reviewed
Dec 12, 2025
app/src/main/java/helium314/keyboard/latin/AudioAndHapticFeedbackManager.java
Outdated
Show resolved
Hide resolved
eranl
reviewed
Dec 12, 2025
| return; | ||
| } | ||
|
|
||
| // if (repeatCount % PERIOD_FOR_AUDIO_AND_HAPTIC_FEEDBACK_IN_KEY_REPEAT == 0) { |
Contributor
There was a problem hiding this comment.
Why is code here commented out?
Comment on lines
+549
to
+551
| <string name="prefs_keypress_vibration_mode_off">Off</string> | ||
| <string name="prefs_keypress_vibration_mode_system">System default</string> | ||
| <string name="prefs_keypress_vibration_mode_custom">Custom</string> |
Contributor
There was a problem hiding this comment.
Missing comments here, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! First, thanks for the app, it's absolutely great! <3
This PR introduces an option to change vibration amplitude (maybe the user-facing name should be changed to something more appropriate). Here is what I have done:
PreferencesScreento easily toggle betweenoff/system/customvibration modes, this also allows to simplify the logic.I've also made sure to test the vibration related functions, and they appear to be working correctly.
Again, thanks for your time, your work is greatly appreciated!