Fix: replace bare catch with FormatException catch and logging in GetRealTimeOdds#32
Open
HashidaTKS wants to merge 1 commit intomasterfrom
Open
Fix: replace bare catch with FormatException catch and logging in GetRealTimeOdds#32HashidaTKS wants to merge 1 commit intomasterfrom
HashidaTKS wants to merge 1 commit intomasterfrom
Conversation
…TimeOdds
A bare catch{} in the horse number parsing loop silently swallowed all
exceptions including non-recoverable ones, and gave no diagnostic information.
Narrow to FormatException (the only expected failure when int.Parse encounters
a non-numeric string) and log the exception before continuing so parse failures
are observable in the log.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
問題点
Scraper.GetRealTimeOdds()内の馬番号パース処理でcatch {}を使用していた（line 241-243）。OutOfMemoryException等の回復不能な例外も継続処理してしまう改善内容
catchをcatch (FormatException ex)に変更（int.Parseが失敗する唯一の想定例外）LoggerWrapper.Warn(ex)でログを記録してからcontinueTest plan
FormatExceptionがキャッチされてログが出力されることを確認🤖 Generated with Claude Code