Fix: add null checks in RssAccessor.GetData#30
Open
HashidaTKS wants to merge 1 commit intomasterfrom
Open
Conversation
…sAccessor
element.Element("channel") returns null when the RSS feed lacks a <channel>
element, causing NullReferenceException on channelElement.Elements("item").
Similarly, each <item>'s child elements (title/link/description) can be
absent, causing Value access on null XElement.
Add a null guard for channelElement returning an empty sequence, and filter
out items that are missing required child elements before constructing RssDatum.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
問題点
RssAccessor.GetData()で以下の null チェックが欠如していた。element.Element("channel")の戻り値 — RSS フィードに<channel>要素がない場合にnullが返り、続く.Elements("item")でNullReferenceException<item>の子要素 (title/link/description) — 要素が存在しない場合に.ValueアクセスでNullReferenceException改善内容
channelElement == nullの場合は空のシーケンスを返すtitle/link/descriptionのいずれかが欠損している<item>はフィルタリングしてRssDatum生成をスキップTest plan
<channel>要素が存在しない RSS フィードでも例外が発生しないことを確認<item>がスキップされることを確認🤖 Generated with Claude Code