Fix: use Path.GetTempPath() for temporary file in Serialize#22
Open
HashidaTKS wants to merge 1 commit intomasterfrom
Open
Fix: use Path.GetTempPath() for temporary file in Serialize#22HashidaTKS wants to merge 1 commit intomasterfrom
HashidaTKS wants to merge 1 commit intomasterfrom
Conversation
.\{random} depends on the process working directory, which varies by
deployment environment and can be unpredictable. Use the OS temp directory
via Path.GetTempPath() to ensure the file is always written to a known,
writable location regardless of where the application is launched from.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
問題点
XmlSerializerWrapper.Serialize()内のテンポラリファイルパスとして.\{random}という相対パスを使用していた。これはプロセスの作業ディレクトリに依存するため、アプリケーションの起動方法や配置環境によって予期しない場所にファイルが生成される可能性があった。また権限の問題でファイル生成に失敗するリスクもあった。
改善内容
$@".\{Path.GetRandomFileName()}"をPath.Combine(Path.GetTempPath(), Path.GetRandomFileName())に変更Test plan
🤖 Generated with Claude Code