refactor: set_value_at_key — drop redundant triplets token and rc4 aliases#59
Merged
Conversation
…iases data.triplets.set_triplets_value_at_key stuttered; "value at key" already names the VALUE/KEY columns and there is no tableview variant to disambiguate. Renamed set_triplets_value_at_key(_and_id) to set_value_at_key(_and_id) everywhere. The rc4-only set_triplets_value_by_key(_and_id) spellings are dropped without aliases — rc missteps are bugs, not API; only the stable 0.0 names (set_VALUE_at_KEY[_and_ID]) keep deprecation aliases, now pointing at the new names. Migration guide updated: rename table, rc4 misnaming note, and the strings-or-null section references.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
data.triplets.set_triplets_value_at_key stuttered; "value at key"
already names the VALUE/KEY columns and there is no tableview variant
to disambiguate. Renamed set_triplets_value_at_key(_and_id) to
set_value_at_key(_and_id) everywhere.
The rc4-only set_triplets_value_by_key(_and_id) spellings are dropped
without aliases — rc missteps are bugs, not API; only the stable 0.0
names (set_VALUE_at_KEY[_and_ID]) keep deprecation aliases, now
pointing at the new names.
Migration guide updated: rename table, rc4 misnaming note, and the
strings-or-null section references.