refactor: set_triplets_value_at_key — restore "at" from the original name#57
Merged
Conversation
…name set_VALUE_at_KEY was renamed to set_triplets_value_by_key in #45; "at" was the right preposition (value AT a key, not BY). Renamed to set_triplets_value_at_key(_and_id) everywhere; the rc4 _by_ spellings keep working as DeprecationWarning aliases. Migration guide updated: corrected rename table + note about the rc4 naming, and a new section documenting the strings-or-null triplets invariant from #56 (nullable string roundtrips, set-value normalization).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set_VALUE_at_KEY was renamed to set_triplets_value_by_key in #45;
"at" was the right preposition (value AT a key, not BY). Renamed to
set_triplets_value_at_key(_and_id) everywhere; the rc4 by spellings
keep working as DeprecationWarning aliases.
Migration guide updated: corrected rename table + note about the rc4
naming, and a new section documenting the strings-or-null triplets
invariant from #56 (nullable string roundtrips, set-value
normalization).