fix: tolerate non-string VALUEs in cython cimxml export, check columns (#50)#53
Merged
Conversation
#50) The compiled export crashed with "Expected bytes, got a 'int' object" when VALUE contained numbers (natural after tableview roundtrips with string_to_number=True, or user edits) — the lxml engine formats them silently, so the engines disagreed. _string_array now goes through astype("string[pyarrow]"): any input dtype becomes text (matching lxml's formatting), nulls stay null, and it is 14x faster than the old astype(object) path for clean arrow columns (8 ms vs 112 ms per 1.14M-row column). Arrow-backed columns arrive as ChunkedArray; combined to the single contiguous array the C++ extension requires. export_to_cimxml and export_to_nquads now fail early with a clear message when required triplet columns are missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compiled export crashed with "Expected bytes, got a 'int' object"
when VALUE contained numbers (natural after tableview roundtrips with
string_to_number=True, or user edits) — the lxml engine formats them
silently, so the engines disagreed.
_string_array now goes through astype("string[pyarrow]"): any input
dtype becomes text (matching lxml's formatting), nulls stay null, and
it is 14x faster than the old astype(object) path for clean arrow
columns (8 ms vs 112 ms per 1.14M-row column). Arrow-backed columns
arrive as ChunkedArray; combined to the single contiguous array the
C++ extension requires.
export_to_cimxml and export_to_nquads now fail early with a clear
message when required triplet columns are missing.