Fix intraday-timestamp crash in trading-date scheduling (#69)#264
Open
MBemera wants to merge 1 commit into
Open
Fix intraday-timestamp crash in trading-date scheduling (#69)#264MBemera wants to merge 1 commit into
MBemera wants to merge 1 commit into
Conversation
Position data ships dates like '2025-10-01 10:00:00', but get_trading_dates parsed them with a date-only strptime, raising 'unconverted data remains: 11:00:00' on 'python3 main.py'. The US agent had an ad-hoc split() guard; the A-share and crypto agents did not. Centralize the duplicated logic into tools.price_tools.compute_trading_dates, parsing every date field with the existing utils.date_utils.parse_date (which accepts both 'YYYY-MM-DD' and 'YYYY-MM-DD HH:MM:SS'), and iterate on calendar dates so an intraday timestamp cannot drop the final day. The three daily agents now delegate to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #69.
get_trading_datescrashed on timestamped position dates (unconverted data remains). Now parses them via the tolerantparse_date.