Move filtering code into hera_filters. - #144
Open
aewallwi wants to merge 1 commit into
Open
Conversation
Member
|
As I suggested in the other info, can we leave a skeleton here that runs existing functions in hera_filters (without necessarily importing it at the top level)? Like |
Collaborator
|
@jsdillon @tyler-a-cox @aewallwi I think someone should take over just getting this PR in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move filtering code out of
uvtoolsinto thehera_filtersrepository.hera_filtersis at https://github.com/HERA-Team/hera_filters . The reason for this change is that foreground filtering is widely applicable beyond HERA and it makes sense to decouple it from the visualization functionality inuvtoolsand the associated dependancies. We may want to change the name ofuvtoolstohera_visualizationif we decide to add substantially more plotting functionality in the future.For now, I've preserved
uvtools.dspecand just importhera_filtersmethods. In a future PR (after people have had time to migrate downstream code) we should probably completely eliminateuvtools.dspec.