Phase wraps - #110
Open
r-pascua wants to merge 9 commits into
Open
Conversation
The code in plot.labeled_waterfall was updated to ensure that phase-wrapped LSTs are labeled correctly and was implemented in a way such that Fourier modes are still plotted symmetrically without issue. These updates should remove the issues that cropped up with the previous implementation.
The note added is a brief discussion on subtle, seemingly buggy, behavior around plotting data with phase wrapped LSTs. It provides tips to users who may not be very familiar with UVData objects and the issue of appropriately extracting unique phase-wrapped LSTs without messing up the ordering of the LST array.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
==========================================
- Coverage 62.55% 61.84% -0.72%
==========================================
Files 5 5
Lines 1469 1486 +17
==========================================
Hits 919 919
- Misses 550 567 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
steven-murray
left a comment
steven-murray
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @r-pascua, maybe we should get this merged 😆
| vmin=None, | ||
| vmax=None, | ||
| dynamic_range=None, | ||
| Nticks=6, |
Collaborator
There was a problem hiding this comment.
Let's try to use standard python formatting for variables
Suggested change
| Nticks=6, | |
| n_ticks=6, |
| raise TypeError("array-like data must consist of complex numbers.") | ||
| if data.ndim != 2 or (data.ndim == 2 and 1 in data.shape): | ||
| raise ValueError("array-like data must be 2-dimensional.") | ||
| if type(Nticks) is not int: |
Collaborator
There was a problem hiding this comment.
Suggested change
| if type(Nticks) is not int: | |
| if not isinstance(n_ticks, int): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a silent bug in
plot.labeled_waterfall: prior to this update, the LST axis ticklabels were incorrect when the provided LSTs were wrapped. For example, if the LST array started at 23 hours and ended at 5 hours, then the plotting function would have listed the LST values as ranging from 5 hours to 23 hours, rather than wrapping from 23 hours to 5 hours--this update fixes that problem.