use pyproj.toml, src layout - #677
Conversation
david-deboer
left a comment
david-deboer
left a comment
There was a problem hiding this comment.
Looks fine to me. The only question is the url. postgresql -> postgresql+psycopg. I'm assuming that is correct and then not related to the CI having issues?
I think it was a mistake. That change should only be made for sqlalchemy access to postgres, not to the actual postgres server. I fixed it and it's making it past that step (there's a new error I'm working on). Thanks for pointing it out! |
also apply branch version fixes developed in rasg repos
Also removed that from example configs as I think the configs should be tied to the true postgres url not to the sqlalchemy url hack. And fixed a test that let a test table persist in the test database, which caused sqlite parse errors.
4f51b1b to
6257738
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #677 +/- ##
===========================================
- Coverage 98.13% 80.44% -17.70%
===========================================
Files 34 34
Lines 5312 5312
===========================================
- Hits 5213 4273 -940
- Misses 99 1039 +940 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| omit = | ||
| */tests/* | ||
| */docs/* | ||
| branch = false |
There was a problem hiding this comment.
punted turning this on, made an issue for now (#679)
that version no longer requires the deprecated pkg_resources
3 participants
Description
This is a modernization/reorganization to a src layout (allows better testing) and using pyproj.toml instead of setup.py to define the package (the current setup.py approach is deprecated).
I actually did this work several months ago but was waiting for #675 to be merged to get this in.
Motivation and Context
Types of changes
Checklist:
Build or continuous integration change checklist:
Other:
changes when this is merged.