Skip to content

Fix "make distcheck"#114

Merged
bryanirby merged 5 commits intoHEASARC:developfrom
wrp:add-check-target
Jan 16, 2026
Merged

Fix "make distcheck"#114
bryanirby merged 5 commits intoHEASARC:developfrom
wrp:add-check-target

Conversation

@wrp
Copy link
Copy Markdown
Contributor

@wrp wrp commented Dec 24, 2025

The 'distcheck' recipe should work, and it should execute the test suite. This PR adds a wrapper script to invoke testprog and adds all the necessary source files to the distribution tarball so that the distcheck target can run.

This PR stacks on #113. Since all of the autotool meta-data files are included in the repository, the diff appears significant, but this is just few lines in Makefile.am and the addition of the run-test script.

@esabol
Copy link
Copy Markdown
Contributor

esabol commented Dec 24, 2025

There's already a test for this in https://github.com/HEASARC/cfitsio/blob/develop/.github/workflows/ci.yml, so there's some redundancy here with your run-test script. If this were to be merged, the CI workflow should be modified to use your run-test script.

@wrp wrp force-pushed the add-check-target branch 2 times, most recently from f2b661a to f528033 Compare December 25, 2025 00:19
@esabol
Copy link
Copy Markdown
Contributor

esabol commented Dec 25, 2025

Thank you for adding the modifications to the ci.yml. 👍

@wrp wrp force-pushed the add-check-target branch 2 times, most recently from 23d127d to 204543c Compare December 26, 2025 18:04
@bryanirby bryanirby self-assigned this Jan 9, 2026
@wrp wrp force-pushed the add-check-target branch 3 times, most recently from 5c73e15 to 0a9033d Compare January 11, 2026 15:32
bryanirby
bryanirby previously approved these changes Jan 13, 2026
@bryanirby bryanirby dismissed their stale review January 13, 2026 17:43

Checks failed, need to re-review

@bryanirby
Copy link
Copy Markdown
Collaborator

Hi @wrp - I'm unable to merge this PR due to failed checks resulting from a missing "check-TESTS" target. It's possible things got mangled during my review and attempted conflict resolution, but I see the same error when running 'make distcheck' on your add-check-target branch. Are you able to comment on this issue? Thanks.

wrp added 5 commits January 14, 2026 18:13
Users of autoconfiscated packages expect to be able to run "make check"
to run the test suite.
The script is strictly a wrapper around testprog, and the name
should reflect its use more accurately.
@wrp wrp force-pushed the add-check-target branch from 12630c2 to f80456f Compare January 15, 2026 01:15
@wrp
Copy link
Copy Markdown
Contributor Author

wrp commented Jan 15, 2026

Rebased. 'make distcheck' works for me locally and is passing in the github runners. Looks like the rebase restored the autoreconf changes to Makefile.in

Copy link
Copy Markdown
Collaborator

@bryanirby bryanirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do note that 'make distcheck' seems fragile on some systems. If a UID is greater than 2^21 - 1 (which mine are on our Macs) the configure decides that the UID is "not supported by ustar format", and this then results in a make failure with little information about the cause. Closer inspection reveals that the UID setting causes the am__tar variable (intended for tar, gtar, gnutar) to be "none", which leads to the make distcheck error.

@bryanirby bryanirby merged commit 2d1b464 into HEASARC:develop Jan 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants