Skip to content

Skip queuing of blank Email and SMS #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GregFinzer merged 1 commit into from
Aug 8, 2026
Merged

Skip queuing of blank Email and SMS #758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions BedBrigade.Data/Services/EmailQueueDataService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,11 @@ public async Task<ServiceResponse<bool>> DeleteQueuedBySignUpId(int signUpId)

public async Task<ServiceResponse<string>> QueueEmail(EmailQueue email)
{
if (string.IsNullOrWhiteSpace(email.ToAddress))
{
return new ServiceResponse<string>("Blank email, skipping", true);
}

var duplicate = await GetDuplicateEmails(email);

if (duplicate != null)
Expand Down
5 changes: 5 additions & 0 deletions BedBrigade.Data/Services/SmsQueueDataService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,6 +563,11 @@ public async Task<ServiceResponse<string>> QueueBulkSms(int locationId, List<str
//This is currently only used by QueueDeliverySmsReminder and QueueSignUpSmsReminder
public async Task<ServiceResponse<string>> QueueSms(SmsQueue smsQueue)
{
if (string.IsNullOrWhiteSpace(StringUtil.ExtractDigits(smsQueue.ToPhoneNumber)))
{
return new ServiceResponse<string>("Blank phone number, skipping", true);
}

var duplicate = await GetDuplicateSms(smsQueue);

if (duplicate != null)
Expand Down
Loading