Fix SUSE Linux Micro 6+ - #628
Conversation
|
Hi @rjschwei. Thanks for your PR. I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
| isSles16 := strings.Contains(osInfo.OS, "sles") || strings.Contains(osInfo.OS, "opensuse") | ||
| if !isSles16 || osInfo.Version.Major != 16 { | ||
| isSles16 := strings.Contains(osInfo.OS, "sles") || strings.Contains(osInfo.OS, "opensuse") | ||
| isSLMicro := := strings.Contains(osInfo.OS, "sl-micro") |
There was a problem hiding this comment.
Thanks for the PR @rjschwei
There seems to build failure due to duplicate :=.
Also, while we're modifying this do you mind changing this to something like this for readabilit
isSles := strings.Contains(osInfo.OS, "sles") || strings.Contains(osInfo.OS, "opensuse") || strings.Contains(osInfo.OS, "sl-micro")
if !isSles || osInfo.Version.Major != 16 {
return nil
}
Based on this major version from VERSION_ID for sl-micro is also 16
There was a problem hiding this comment.
@ChaitanyaKulkarni28 I fixed the fat finger issue with the double ":=" The table you reference is not relevant to this. The table was created after Micro 6.2 was released and os-release will not change retroactively. Meaning the versions for micro 6+ are 6.0, 6.1 and 6.2. There will not be a Micro 6.3. Going forward starting with SLES 16.1 there will be an "immutable" mode that replaces the Micro product.
f4d57da to
60d4b36
Compare
SUSE Linux Micro 6+ is based on the SLES 16 code base and we need to account for the same semantics as in SLES 16. Recognize SL Micro and handle it appropriately. Thanks to @lidong Zhong from the SUSE L3 team.
1c54c71 to
8f67452
Compare
|
@ChaitanyaKulkarni28 sorry need help with the tests, could you please take a look. I added tests to check Micro. Thanks |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChaitanyaKulkarni28, rjschwei The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
SUSE Linux Micro 6+ is based on the SLES 16 code base and we need to account for the same semantics as in SLES 16. Recognize SL Micro and handle it appropriately. Thanks to @lidong Zhong from the SUSE L3 team.