(Possibly Temporary Issue) DF 10.2.6 ilvl labels showing on non-equippables - #2
Open
dumbomb wants to merge 1 commit into
Open
(Possibly Temporary Issue) DF 10.2.6 ilvl labels showing on non-equippables#2dumbomb wants to merge 1 commit into
dumbomb wants to merge 1 commit into
Conversation
|
I have applied this patch locally and it fixes the issue for me 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title says, the most recent retail patch made many unequippable items have ilvl labels such as consumables and crafting reagents.
For some reason this patch added INVTYPE_NON_EQUIP_IGNORE which many items return as ItemEquipLoc.
For example Frostweave Cloth:
Patch 10.2.5:
Patch 10.2.6:
I'm not sure why they can get their ilvl values, but filtering them out of the if statement works correctly.
Easy to change the regular NON_EQUIP string if Blizz removes the IGNORE one later.