Skip to content

fix: add company greeting fallback#79

Open
Ric-TengYi wants to merge 1 commit into
Ghbounty:mainfrom
Ric-TengYi:fix/70-company-greeting-fallback
Open

fix: add company greeting fallback#79
Ric-TengYi wants to merge 1 commit into
Ghbounty:mainfrom
Ric-TengYi:fix/70-company-greeting-fallback

Conversation

@Ric-TengYi
Copy link
Copy Markdown

Fixes #70

Summary

  • add shared display-name helpers for company/user-facing labels
  • fall back to there in the company dashboard greeting when company.name is missing or blank
  • fall back to Company in the app nav so blank names do not render as undefined

Tests

  • corepack pnpm --filter frontend test -- tests/display-names.test.ts
  • corepack pnpm --filter frontend test
  • corepack pnpm typecheck

Note: root corepack pnpm test currently fails in unrelated MCP polling tests in apps/mcp/tests/tools/create-account.test.ts.

@Ric-TengYi Ric-TengYi requested a review from tomazzi14 as a code owner May 13, 2026 06:50
@vercel
Copy link
Copy Markdown

vercel Bot commented May 13, 2026

Someone is attempting to deploy a commit to the weareghbounty-6269's projects Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: dashboard greeting shows 'Hello, undefined' for users without a name

1 participant