fix: ignore Anchor generated directory#75
Open
MolhamHamwi wants to merge 1 commit into
Open
Conversation
|
@MolhamHamwi is attempting to deploy a commit to the weareghbounty-6269's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull request overview
Updates @ghbounty/diff-filter to treat Anchor’s .anchor/ output directory as generated content so it’s ignored during diff filtering, reducing noise from Solana/Anchor build artifacts (per #67).
Changes:
- Add
.anchor/toGENERATED_DIR_PREFIXESso both top-level and nested.anchor/paths are filtered. - Add test cases to ensure
.anchor/paths are classified asgenerated_dir.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/diff-filter/src/patterns.ts | Adds .anchor/ to the generated directory prefix list so Anchor artifacts are ignored. |
| packages/diff-filter/tests/classify.test.ts | Adds coverage for both nested and top-level .anchor/ paths in generated-dir classification tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.anchor/to generated directory prefixes in@ghbounty/diff-filter.anchor/generated paths in classify testsVerification
pnpm --filter @ghbounty/diff-filter testpnpm --filter @ghbounty/diff-filter typecheckpnpm typecheckpnpm testCloses #67