feat: Support Roundcube 1.7 static files handling

[GermanCoding]

Roundcube 1.7 forces us to go through static.php for security. However, this script does not exist in older Roundcube releases. To maintain backwards compatibility, figure out the correct path at runtime depending on the version.

Fixes #33

[GermanCoding]

As we do not have full E2E testing, I manually gave this a spin with 1.7-RC6 (in docker), and confirmed that this works as intended.

[GermanCoding]

Note: Reading the current Roundcube code, there may be a simpler alternative: Instead of parsing the Roundcube version ourselves, we could call asset_url which handles the static.php redirection automatically on RC1.7 (and this function also exists on older versions)

[GermanCoding]

Redesigned to switch to asset_url function instead, much simpler now. Tested it, appears to work. Inclined to merge this ASAP as Roundcube 1.7 was released today.

[Copilot]

Pull request overview

Adds Roundcube 1.7-compatible handling for plugin static assets by routing icon URLs through Roundcube’s asset URL resolver, while preserving legacy behavior for older versions.

Changes:

• Introduce get_svg_path() and update message header rendering to use asset_url() for icon src values.
• Refactor PHPUnit expectations to derive icon URLs from the plugin helper and add stub-based tests for legacy vs static.php URL generation.
• Update README to note testing up to Roundcube 1.7.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
tls_icon.php	Uses Roundcube’s asset URL resolution for SVG icon URLs to support 1.7 static.php handling.
test/TlsIconTest.php	Refactors expected HTML strings and adds unit tests around asset URL stubbing.
test/rcmail.php	Extends the Roundcube test stub to include output->asset_url() behavior via a callback.
README.md	Documents compatibility testing up to Roundcube 1.7.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• plugins.roundcube.net
  • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/Cbqa0P /usr/bin/composer install --no-interaction (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[williamdes]

💯