upgrade svelte3 to svelte4 and migrated to the latest sveltekit with svelte package#7
Open
JinIgarashi wants to merge 2 commits into
Open
upgrade svelte3 to svelte4 and migrated to the latest sveltekit with svelte package#7JinIgarashi wants to merge 2 commits into
JinIgarashi wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@GeoffCox Thanks for developing this awesome svelte library!
There is a problem of using this library in my repo in the latest sveltekit environment. I migrated the package to svelte4 and sveltekit.
I did some minor changes on your code for fixing lint error, but I did not change anything about the current interface.
I did following:
npm create svelte@latest ., then simply migrated all files. demo folter is moved to underroutes, package folder is moved to underlib.I deployed my version to @watergis/svelte-splitter on npm, and this works fine in my project.
If everything is good, could you merge this and bump a major version for
@geoffcox/svelte-splitter?