fix: define PRECISION in gathera_common, import across workspace#585
Open
Alqku wants to merge 1 commit into
Open
fix: define PRECISION in gathera_common, import across workspace#585Alqku wants to merge 1 commit into
Alqku wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
storage.rsreferencedcrate::cross_chain::PRECISIONwhich ispub(crate)incross_chain.rs. This caused a compile error and accidental coupling between modules. The fix movesPRECISIONtogathera_commonas the single source of truth.Changes
contract/common/src/lib.rs: addpub const PRECISION: i128 = 1_000_000_000with a doc-comment explaining its role.contract/contracts/src/storage.rs: importgathera_common::PRECISIONand replace bothcrate::cross_chain::PRECISIONreferences inupdate_reward.contract/contracts/src/cross_chain.rs: remove the localpub(crate) const PRECISIONand re-import fromgathera_commonfor any remaining internal use.Testing
cargo check --workspaceexits 0 with no undefined-constant errors.update_rewardarithmetic is unchanged; only the import source differs.Closes #513