fix: wire DB pool sizing via env (DATABASE_POOL_MIN/MAX, timeouts)#583
Open
snowrugar-beep wants to merge 1 commit into
Open
fix: wire DB pool sizing via env (DATABASE_POOL_MIN/MAX, timeouts)#583snowrugar-beep wants to merge 1 commit into
snowrugar-beep wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DB pool size, idle timeout, statement timeout, and max lifetime were hardcoded. Staging and production could not be tuned without a code change, causing cold-start failures under load.
Changes
app/backend/src/app.module.ts: switchTypeOrmModule.forRoottoforRootAsync, injectConfigService, and passDATABASE_POOL_MIN,DATABASE_POOL_MAX,IDLE_TIMEOUT_MS,STATEMENT_TIMEOUT_MS,MAX_LIFETIME_MSfrom env with safe defaults.app/backend/.env.example: document all five new env vars with default values and comments.Testing
DATABASE_POOL_MAX=2and send concurrent requests beyond the pool — server returns 503 (pool saturation), not a 500 crash.Closes #526