Multisig wallet contract#558
Merged
Merged
Conversation
Contributor
|
Multisig wallet contract @clintjeff2 is solid work, appreciate it ✅ Merging! |
Contributor
|
@clintjeff2 — quick follow-up: real merge conflicts against main now. Please rebase onto main and I'll merge on the next push. 🙏 |
- Replaced skeleton methods with full state machine logic. - Implemented actual contract invocation in `execute_transaction`. - Secured governance methods with internal-only access via multisig. - Added counter-based unique transaction IDs (no-std compatible). - Added rejection for self-approvals. - Implemented comprehensive security and logic tests. Co-authored-by: clintjeff2 <119521983+clintjeff2@users.noreply.github.com>
clintjeff2
force-pushed
the
multisig-wallet-contract
branch
from
98be7f0 to
657052a
Compare
clintjeff2
force-pushed
the
multisig-wallet-contract
branch
from
334bd6b to
2205cb8
Compare
Contributor
Author
|
@Xhristin3 please review and merge. If there is a way to review contributors, I'd have loved to get one |
Contributor
I sure will. Thanks. |
Contributor
Author
|
@Xhristin3 More issues please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
MultisigWalletContracthas been transformed from a "Not Implemented" skeleton into a fully functional and secure multi-signature wallet.Key Changes:
initialize,submit_transaction,approve_transaction, andexecute_transactionwith robust state transitions (Pending -> Approved -> Executed/Expired).env.invoke_contractonce the required threshold is met.add_owner,remove_owner, andchange_thresholdnow require authentication from the contract itself, meaning they are only reachable through the multisig's own execution path.format!and ensuring compatibility with Soroban's WASM target.Closes #500