chore: update PR knowledge base

[Galzi1]

Automated update of the PR knowledge base.

[qodo-code-review]

ⓘ You are approaching your monthly quota for Qodo. Upgrade your plan

Review Summary by Qodo

Add gotcha documentation for discount calculation edge cases

📝 Documentation

Walkthroughs

Description

• Added two new gotcha entries to knowledge base
• Documents discount calculation edge cases and validation issues
• Updated manifest and index with new knowledge base entries
• Captures issues with capped percentage discount function behavior

Diagram

flowchart LR
  KB["Knowledge Base"]
  Manifest["kb/.manifest.json"]
  Index["kb/INDEX.md"]
  Gotcha1["gotcha/discount-calculation-can-exceed-subtotal.md"]
  Gotcha2["gotcha/negative-max-discount-amount.md"]
  
  KB --> Manifest
  KB --> Index
  KB --> Gotcha1
  KB --> Gotcha2
  Manifest -- "register entries" --> Gotcha1
  Manifest -- "register entries" --> Gotcha2
  Index -- "list gotcha" --> Gotcha1
  Index -- "list gotcha" --> Gotcha2

Loading

File Changes

1. kb/.manifest.json 📝 Documentation +3/-1

Register new gotcha entries in manifest

• Added two new gotcha entries to the manifest registry
• Entry 3067725988 maps to negative-max-discount-amount gotcha
• Entry 3067725989 maps to discount-calculation-can-exceed-subtotal gotcha
• Updated trailing comma formatting for JSON validity

kb/.manifest.json

---

2. kb/INDEX.md 📝 Documentation +3/-1

Update index with new gotcha documentation

• Updated Gotcha section count from 8 to 10 entries
• Added two new gotcha entries to the index listing
• Inserted entries describing discount calculation edge cases
• Maintained alphabetical and logical ordering of gotcha items

kb/INDEX.md

---

3. kb/gotcha/discount-calculation-can-exceed-subtotal-and-produce.md 📝 Documentation +51/-0

Document discount exceeding subtotal edge case

• Documents issue where discount can exceed subtotal producing negative totals
• Describes root cause lacking bounds checking on discount amount
• Provides fix with discount capping and subtotal clamping logic
• Includes code example showing the problematic function implementation

kb/gotcha/discount-calculation-can-exceed-subtotal-and-produce.md

---

View more (1)

4. kb/gotcha/negative-max-discount-amount-silently-converts-a-discount.md 📝 Documentation +44/-0

Document negative discount amount validation issue

• Documents issue where negative max_discount_amount converts discount to surcharge
• Explains root cause of missing input validation on parameter
• Recommends adding ValueError for negative values and defensive clamping
• Includes code snippet showing the vulnerable function implementation

kb/gotcha/negative-max-discount-amount-silently-converts-a-discount.md

---

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (1)   📘 Rule violations (0)   📎 Requirement gaps (0)   🎨 UX Issues (0)

🐞\ ⚙ Maintainability (1)

1. Missing trailing newline 🐞 ⚙

Description

kb/.manifest.json is committed without a final newline (PR diff shows “No newline at end of file”),
which can cause noisy future diffs and warnings in newline-sensitive tooling.

Code

kb/.manifest.json[R21-23]

+  "3067725988": "gotcha/negative-max-discount-amount-silently-converts-a-discount.md",
+  "3067725989": "gotcha/discount-calculation-can-exceed-subtotal-and-produce.md"
}

Evidence

The manifest is a tracked generated artifact (staged by the workflow) and the PR diff indicates it
lacks a trailing newline; keeping generated text files newline-terminated avoids spurious diffs and
tooling edge cases.

kb/.manifest.json[19-23]
.github/workflows/github-pr-kb.yml[225-233]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`kb/.manifest.json` is missing a trailing newline at end-of-file, which can create unnecessary diff churn and trigger newline-related tooling warnings.

### Issue Context
This file is staged and published by the KB workflow, so keeping it consistently formatted helps keep the rolling KB PR clean.

### Fix Focus Areas
- kb/.manifest.json[19-23]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

ⓘ The new review experience is currently in Beta. Learn more

[Galzi1]

Closing this automation PR because it was generated from Qodo issue comments that arrived after the feature PR merge. The extractor now ignores all Qodo issue comments, and the demo will be rerun on that final behavior.