chore: update PR knowledge base

[Galzi1]

Automated update of the PR knowledge base.

[qodo-code-review]

Review Summary by Qodo

Add knowledge base with tax calculation timing documentation

📝 Documentation

Walkthroughs

Description

• Add knowledge base index and manifest files
• Document tax calculation timing business rule
• Create domain knowledge entry from PR comment

Diagram

flowchart LR
  KB["Knowledge Base"] --> MANIFEST["Manifest File"]
  KB --> INDEX["Index File"]
  KB --> DOMAIN["Domain Knowledge"]
  DOMAIN --> TAX["Tax Calculation Timing Rule"]

Loading

File Changes

1. kb/.manifest.json 📝 Documentation +3/-0

Add knowledge base manifest mapping

• Creates manifest file mapping PR comment IDs to knowledge base entries
• Maps comment ID 4223530384 to tax calculation timing documentation

kb/.manifest.json

---

2. kb/INDEX.md 📝 Documentation +5/-0

Create knowledge base index

• Creates index file for knowledge base organization
• Lists domain knowledge entries with links to detailed documentation
• Includes one domain knowledge entry about tax calculation timing

kb/INDEX.md

---

3. kb/domain_knowledge/tax-calculation-timing-relative-to-discounts-is-a-business.md 📝 Documentation +25/-0

Document tax calculation timing business rule

• Documents business rule about tax calculation timing relative to discounts
• Includes metadata from source PR comment with author and date information
• Explains that tax is applied to subtotal after discounts are deducted
• Provides context, key insight, and implications sections

kb/domain_knowledge/tax-calculation-timing-relative-to-discounts-is-a-business.md

---

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (1)   📘 Rule violations (0)   📎 Requirement gaps (0)   🎨 UX Issues (0)

🐞\ ⚙ Maintainability (1)

1. Missing EOF newline 🐞 ⚙

Description

kb/.manifest.json is committed without a trailing newline, which can cause noisy diffs and can fail
repositories that enforce newline-terminated text files. This file is also explicitly staged by the
publishing workflow, so the formatting will persist once merged.

Code

kb/.manifest.json[R1-3]

+{
+  "4223530384": "domain_knowledge/tax-calculation-timing-relative-to-discounts-is-a-business.md"
+}

Evidence

The PR diff explicitly indicates the manifest has no final newline, and the workflow stages
kb/.manifest.json for publication, so the file will remain in that state when merged.

kb/.manifest.json[1-3]
.github/workflows/github-pr-kb.yml[225-235]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`kb/.manifest.json` is missing a trailing newline at EOF, which can create noisy diffs and may violate newline-terminated text file conventions.

### Issue Context
This file is staged by the automation workflow (`git add -- 'kb/.manifest.json'`), so its formatting will persist in the generated KB updates.

### Fix Focus Areas
- kb/.manifest.json[1-3]

### Expected change
Ensure the file ends with a final `\n` after the closing `}`.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

ⓘ The new review experience is currently in Beta. Learn more