Test branch for building with GHC 9.10 and 9.12#2973
Draft
sauclovian-g wants to merge 4 commits into
Draft
Conversation
Contributor
Author
|
Looks like we first need to teach argo about newer ghc... |
Contributor
Author
|
ok, it solved finally, and the build fails on -Werror, which is precisely what I was doing this for. I'll fix it... |
sauclovian-g
force-pushed
the
ghc-10-12
branch
2 times, most recently
from
9854526 to
d59f33a
Compare
Contributor
Author
|
Looks like we do need SAW changes for the recent Cryptol renamer changes, and this branch should wait for those. |
sauclovian-g
force-pushed
the
ghc-10-12
branch
2 times, most recently
from
a3f6b08 to
5c4f996
Compare
sauclovian-g
force-pushed
the
ghc-10-12
branch
8 times, most recently
from
b0bec8d to
a8b176d
Compare
Contributor
Author
|
ok, it builds with 9.10 and we're down to a Crucible build error on 9.12; unfortunately it's one I don't understand... |
Contributor
|
See GaloisInc/crucible#1828 (comment) for my diagnosis of what is causing Crucible to fail to build with GHC 9.12. |
Contributor
Author
|
Thank you :-) Wasn't going to get very far on that one on my own... |
- ring-buffer doesn't allow ghc 9.12's base - boomerang doesn't allow ghc 9.12's template-haskell
These are copied from the 9.8 ones and minimally updated based on the table on haskell.org of versions shipped with GHC: https://gitlab.haskell.org/ghc/ghc/-/wikis/commentary/libraries/version-history We must use os-string 2.0.7 with 9.10 and 9.12, even though we're using a newer version with older GHC, because as of 9.10 it's included with GHC and we must use exactly that version. On both 9.10 and 9.12, we need newer versions of hashable, lens, and doctest. On 9.12, we need a newer th-abstraction. (note: this commit is dated in January but is up to date as of May 14)
This is a temporary commit to see what happens, contains changes we don't want for real, and should be dropped and replaced once the builds actually run.
Contributor
Author
|
Most of this is merged now via #3252. What's left is waiting on Crucible to build with 9.12, which is happening in GaloisInc/crucible#1828. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there are code changes we need to work with newer GHC, it would be good to get them into 1.5.