This repository was archived by the owner on Jun 10, 2025. It is now read-only.
Add marker button#74
Open
rakrakon wants to merge 14 commits into
Open
Conversation
rakrakon
commented
Nov 11, 2024
rakrakon
commented
Contributor
- Create MarkerCommands
- Create markEvent command
- Create markAbnormalEvent command
- Attach button to markAbnormalEvent command
- Add missing import
katzuv
reviewed
Nov 11, 2024
| import edu.wpi.first.wpilibj2.command.Command | ||
| import edu.wpi.first.wpilibj2.command.Commands | ||
|
|
||
| const val ABNORMAL_EVENT_NAME = "EVENT" |
Member
There was a problem hiding this comment.
I'd add the time since match start/match end. Did you check it's convenient in the console tab? I would also add error/warning so AdvantageScope will color it (check their docs for the exact wording).
Contributor
Author
There was a problem hiding this comment.
I think this is kind of redundant because if we view it through AdvantageScope we can already see the timeline.
Emma03L
reviewed
Nov 11, 2024
Member
|
Looks like you need to change the base branch |
Member
|
This PR is not relevant, we have another repo now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.