Use the correct event to render the HUD to benefit from HUD Caching - #25
Draft
Alexdoru wants to merge 2 commits into
Draft
Use the correct event to render the HUD to benefit from HUD Caching#25Alexdoru wants to merge 2 commits into
Alexdoru wants to merge 2 commits into
Conversation
Alexdoru
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it is using the
TickEvent.RenderTickEventto render the HUD, first of all waila is not checking for event phase.START or END which means that currently it is rendering the HUD twice per frame. Moreover using this event doesn't benefit from HUD caching.So I changed it to use the RenderGameOverlay Event to benefit from HUD caching
It also fixes this item shadow bug on the drawers :
Normal:
When you get in close enough range for waila to render, the item in the drawer turns dark
