Skip to content

Restore Apollo actions to track selector track menu #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garrettjstevens merged 1 commit into from
Apr 30, 2026
Merged

Restore Apollo actions to track selector track menu #784

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions packages/jbrowse-plugin-apollo/src/session/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,23 +411,22 @@ export function extendSession(
}))

.views((self) => {
const superTrackActionMenuItems = (
self as unknown as AbstractSessionModel
).getTrackActionMenuItems
const superTrackActions = (self as unknown as AbstractSessionModel)
.getTrackActions
return {
getTrackActionMenuItems(conf: BaseTrackConfig) {
getTrackActions(conf: BaseTrackConfig) {
if (
conf.type === 'ApolloTrack' ||
conf.type === 'ReferenceSequenceTrack'
) {
return superTrackActionMenuItems?.(conf)
return superTrackActions?.(conf)
}
const trackId = readConfObject(conf, 'trackId') as string
const sessionTrackIdentifier = '-sessionTrack'
const isSessionTrack = trackId.endsWith(sessionTrackIdentifier)
return isSessionTrack
? [
...(superTrackActionMenuItems?.(conf) ?? []),
...(superTrackActions?.(conf) ?? []),
{
label: 'Save track to Apollo',
onClick: async () => {
Expand Down Expand Up @@ -480,7 +479,7 @@ export function extendSession(
},
]
: [
...(superTrackActionMenuItems?.(conf) ?? []),
...(superTrackActions?.(conf) ?? []),
{
label: 'Remove track from Apollo',
onClick: async () => {
Expand Down
Loading