Add river routing grid comp#145
Conversation
|
@weiyuan-jiang, @zyj8881357 : When we add River Routing to GEOSlas, I would expect that we also modify the HISTORY template (GEOSldas_HIST.rc), as well as at least one config parameters that turns routing on/off (and possibly more). Do you have a list of what is still missing from this PR? |
|
We already have a option called RUN_ROUTE in our LDAS.rc that turns routing on/off (1/0) which also appears in our "exe"_input_filename template. I think we can continue to use this one (that is what we did in the PR). If you'd like, we can add an option to turn on/off the reservoirs/lakes, but in my view, we don't need to do that because the reservoirs/lakes make the overall simulation better and we can keep less parameters in the config list. |
In addition to what Weiyuan mentioned, we also need a place to store the raw input data for the pre-processing package that converts the raw data to the file "river_input.nc" that would be used by the make_bcs. But maybe this can be done later because any changes in the make_bcs and routing model may affect the pre-processing package. We can first finalize the routing_model and make_bcs, and then work on the pre-processing package. |
|
This line will be changed GEOSldas_GridComp/GEOSldas_App/ldas.py Line 1007 in 211cb1d |
|
@zyj8881357, @weiyuan-jiang : The standard routing configuration in GEOSldas uses a 1-hour time step for routing (
There may be other requirements that need to be verified. |
@zyj8881357 Is the line ready for change? |
@weiyuan-jiang Yes. The path is /discover/nobackup/projects/gmao/bcs_shared/restarts/surface/route/v202601/ . Could you please help me to update it in the code? I am not familiar with the string variable for dir "/discover/nobackup/projects/gmao/bcs_shared/" in the script. Thank you! |
I realized that we don't support RESTART=0 any more. I removed it and gave users a hint |
gmao-rreichle
left a comment
There was a problem hiding this comment.
@weiyuan-jiang @zyj8881357 , see comments below
I have done this test. The runs with and without landice tiles are zero-diff for land and route. |
…route_tile.nc4" to "EASE_tile2pfaf.nc4"; added documentation (ldas.py)
…processing; removed unused ESMF vm variable declarations (GEOS_EnsGridComp.F90)
Update error message for missing route restart file.
|
@zyj8881357 @biljanaorescanin @biljanaorescanin : When you get a chance, please run the usual 0-diff tests for LDAS and the GCM @zyj8881357 : Please do one more check of a routing simulation with the latest GEOSgcm_GridComp and GEOSldas_GridComp branches. cc: @weiyuan-jiang |
@gmao-rreichle I have finished both the zero-diff and scientific test with the latest GEOSgcm_GridComp and GEOSldas_GridComp branches. They work well and can produce reasonable discharge output against with the observations. |
Add river routing module. Replaces #131
If river routing grid comp is added, its checkpoint should be renamed and backed up.
Related PRs:
GEOS-ESM/GEOSgcm_GridComp#1143 (merged)
GEOS-ESM/GEOSgcm_GridComp#1375 (merged)
GEOS-ESM/GEOSldas#850
Testing:
Left for another PR: