Slim PyTAG jar + release automation#360
Open
martinballa wants to merge 3 commits into
Open
Conversation
Adds a second maven-assembly-plugin execution producing target/TAG-pytag.jar (~13MB vs ~404MB for the full TAG.jar), built from a custom descriptor that keeps the core engine, all games, built-in players, and Swing GUI/replay, but excludes the Spark/Hadoop ML-learner, tablesaw analytics, and langchain4j/ google-cloud dependency trees that PyTAG (github.com/martinballa/PyTAG) never touches. Verified end-to-end against the actual PyTAG package via JPype.
SSPPlayerView, SGPlayerView, and GoFishPlayerView called human.stream().toList().getFirst() to derive the local viewing perspective, which throws NoSuchElementException whenever a game runs with no human player (e.g. all-AI games, or PyTAG's RL agents). Match LoveLetterPlayerView's existing pattern of falling back to -1, the sentinel DeckView already uses to mean "no human perspective".
On publishing a GitHub release, builds the project and uploads target/TAG-pytag.jar as an asset named TAG.jar - the exact filename and URL shape (.../releases/latest/download/TAG.jar) that PyTAG's jar_setup.py expects (github.com/martinballa/PyTAG), so PyTAG users can fetch it without any manual build/copy step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maven-assembly-pluginexecution producingtarget/TAG-pytag.jar(~13MB vs ~404MB for the fullTAG.jar), built fromsrc/assembly/pytag-jar.xml. It keeps the core engine, all games, built-in players, and the Swing GUI/replay path, but excludes the Spark/Hadoop ML-learner, tablesaw analytics, and langchain4j/google-cloud dependency trees that PyTAG never touches. Verified end-to-end against the real PyTAG package via JPype (vector + JSON obs examples, multi-agent).NoSuchElementException) inSSPPlayerView,SGPlayerView, andGoFishPlayerViewwhen constructing the GUI with no human player (e.g. all-AI games, or PyTAG's RL agents) - they calledhuman.stream().toList().getFirst()instead of falling back to-1likeLoveLetterPlayerViewalready does. Found while sweeping games to verify the slim jar renders correctly..github/workflows/release-pytag-jar.yml: on publishing a GitHub release, builds the project and uploadstarget/TAG-pytag.jaras an asset namedTAG.jar, matching the URL shape (.../releases/latest/download/TAG.jar) PyTAG'sjar_setup.pyexpects.Test plan
mvn packagebuilds bothTAG.jarandTAG-pytag.jarcleanlyTAG-pytag.jarverified against a realpip install -e .PyTAG checkout (JPype), runningpt-action-masking.py(vector obs, action masking) andma-random.py(JSON obs, multi-agent) to completion