show canceled icon when clicking unusable ability icons#2519
Draft
Zelongczl wants to merge 1 commit intoFreezingMoon:masterfrom
Draft
show canceled icon when clicking unusable ability icons#2519Zelongczl wants to merge 1 commit intoFreezingMoon:masterfrom
Zelongczl wants to merge 1 commit intoFreezingMoon:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
|
@Zelongczl Heya! Seems pretty good, however, the cancel icon doesn't seem to for already used abilities as according to issue specs. It's nice that it also works for hotkeys, but it should trigger for the passive one (Q hotkey) if no abilities are usable atm. |
Member
|
@Zelongczl Heya! Can you poke at this a bit more so that we can finish with the PR before it goes stale? |
DreadKnight
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #2174
Note: The click of passisve abilities, diabled abilities, noclick abilities, etc. will temporarily display cancel icon