Improve clear#219
Open
ahgittin wants to merge 2 commits into
Open
Conversation
since the usage of `clear([toast])` as optional syntax is confusing to people
seems the destroy call is not always immediate
Author
|
Hi @Foxandxss -- anything I can do to encourage you to merge this? thx! |
Owner
|
I just need time to think, that is a breaking change which forces me a new major version. |
Author
|
@Foxandxss I don't think it breaks the API -- just expands it to accept and the contract of LMK if i can help at all. thx. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per discussion at #137:
clear(toast)doesn't immediately clearclear([toast])should work for a list arg[toast]This fixes both issues.