Skip to content

Add fitsSystemWindows attribute to layout XML files#99

Closed
vibhorgoswami wants to merge 1 commit intomainfrom
fix-account-screen
Closed

Add fitsSystemWindows attribute to layout XML files#99
vibhorgoswami wants to merge 1 commit intomainfrom
fix-account-screen

Conversation

@vibhorgoswami
Copy link
Copy Markdown
Contributor

@vibhorgoswami vibhorgoswami commented Mar 16, 2026

This PR is evaluating Agentic PR review on our GitHub repos
SDKS-4788

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Improved account layout display on Android devices with system UI elements like status bars and navigation bars.

@vibhorgoswami vibhorgoswami self-assigned this Mar 16, 2026
@vibhorgoswami vibhorgoswami marked this pull request as draft March 16, 2026 17:39
@vibhorgoswami vibhorgoswami marked this pull request as ready for review April 2, 2026 18:25
@vibhorgoswami
Copy link
Copy Markdown
Contributor Author

Testing PR Review

@vibhorgoswami vibhorgoswami reopened this Apr 7, 2026
@vibhorgoswami vibhorgoswami requested a review from spetrov April 7, 2026 23:33
@vibhorgoswami vibhorgoswami changed the title [DO NOT MERGE] Add fitsSystemWindows attribute to layout XML files Add fitsSystemWindows attribute to layout XML files Apr 7, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 8, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 89cffaf6-7585-478d-9d3b-20433eb86c9e

📥 Commits

Reviewing files that changed from the base of the PR and between d8da8fb and cfc53b2.

📒 Files selected for processing (1)
  • android/java-authenticator/authenticator/src/main/res/layout/activity_account.xml

📝 Walkthrough

Walkthrough

The activity_account.xml layout file was updated to add the android:fitsSystemWindows="true" attribute to the root LinearLayout. Additionally, formatting adjustments were made to convert multi-line self-closing XML tags to single-line equivalents without altering attribute values.

Changes

Cohort / File(s) Summary
Layout XML Update
android/java-authenticator/authenticator/src/main/res/layout/activity_account.xml
Added android:fitsSystemWindows="true" to root LinearLayout. Reformatted multi-line self-closing tags for TextView and GridView to single-line format. No attribute value changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A layout so tidy, windows now fit,
No more stray brackets or formatting grit,
With one clean attribute, the screen fits just right,
The rabbit hops proudly—the code's looking bright!

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-account-screen

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant