Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #176 +/- ##
==============================================
+ Coverage 27.66% 43.92% +16.25%
- Complexity 901 1218 +317
==============================================
Files 299 305 +6
Lines 8957 9209 +252
Branches 1272 1309 +37
==============================================
+ Hits 2478 4045 +1567
+ Misses 6195 4630 -1565
- Partials 284 534 +250
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Introduced support for PAR (RFC 9126) to improve security and handle large authorization request payloads by pushing parameters to the server prior to authorization. Key changes: - Added `par` configuration flag to `OidcClientConfig` and updated `OpenIdConfiguration` to include the `pushed_authorization_request_endpoint`. - Refactored authorization request building logic into `buildAuthorizeParams` and updated `populateRequest` to handle both standard and PAR flows. - Implemented PAR logic to POST parameters to the provider and utilize the returned `request_uri` in the subsequent authorization call. - Updated `Agent.kt` in the Journey module to use the centralized `populateRequest` logic, ensuring PAR support is available across modules. - Added comprehensive unit and integration tests in `DaVinciTest`, `JourneyTest`, and `OidcWebClientTest` to verify PAR execution and parameter handling. - Updated license headers to include 2026.
witrisna
requested review from
george-bafaloukas-forgerock,
spetrov and
vibhorgoswami
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
SDKS-4231
Description
Introduced support for PAR (RFC 9126) to improve security and handle large authorization request payloads by pushing parameters to the server prior to authorization.
Key changes:
parconfiguration flag toOidcClientConfigand updatedOpenIdConfigurationto include thepushed_authorization_request_endpoint.buildAuthorizeParamsand updatedpopulateRequestto handle both standard and PAR flows.request_uriin the subsequent authorization call.Agent.ktin the Journey module to use the centralizedpopulateRequestlogic, ensuring PAR support is available across modules.DaVinciTest,JourneyTest, andOidcWebClientTestto verify PAR execution and parameter handling.