Conversation
* Use consistent naming (editor instead of view, font options instead of text settings, editor buffer instead of view text) * Split viewport dimensions into viewport position and viewport size * Make viewport size reactive instead of being Held * Remove `ctrl + t` (`ctrl + r` already does the same thing) * `-keep` editor cursor for 12ms * Make editor number line work at both small and large sizes * Separate margin into top/right/bottom/left * Keep at least two characters on the left when moving the cursor left
osnr
reviewed
Dec 26, 2025
| set anchor [list 1.0 0 1 0] | ||
| } elseif {$anchor == "left"} { | ||
| set anchor [list 0 0.5] | ||
| set anchor [list 0 0.5 0 5] |
Collaborator
|
The key bug we're trying to fix here is where the scroll viewport is weirdly small on editor reboot (due to some race in the old way we were doing state) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor editor to fix state issues:
ctrl + t(ctrl + ralready does the same thing)-keep 12msto avoid locking upModify font rendering: