Move V100/MI210/CPU release image builds to GitHub Actions#134
Merged
Conversation
Publish the MI210 (gfx90a), V100 (sm70), and x86 CPU release images from the GitHub Actions docker-publish workflow alongside the existing Blackwell (sm100/sm103) and MI300X (gfx942) targets, in both double- and single-precision variants. MI210 was already migrated in #130; this adds V100 (sm70) and x86 CPU. Wire the SELF_DOUBLE_PRECISION build arg into the x86_sm70 and x86 Dockerfiles so their single-precision variants build correctly, and fix the x86 (CPU) Dockerfile's stale default base image (latest-x86 -> the existing latest-x86-none selfish tag). Disable the buildkite main-branch Release & Publish pipeline and remove the now-superseded release-and-publish.yml; buildkite continues to run the on-hardware GPU coverage tests on pull-request branches. Note that release images are no longer ctested on real hardware before publishing, matching the existing behavior for the Blackwell targets. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
fluidnumericsJoe
force-pushed
the
feature/gha-v100-mi210-cpu-publish
branch
from
a19cbf4 to
eec5901
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates all release-image publishing into the GitHub Actions
docker-publishworkflow and retires the buildkite main-branch release pipeline.docker-publishmatrix (double- + single-precision each):x86-cuda124-sm70x86gfx90awas already migrated in docker-publish: add MI210 (gfx90a) and MI300 (gfx942) image builds #130; B200/B300sm100/sm103and MI300Xgfx942were already there.)SELF_DOUBLE_PRECISIONintodocker/x86_sm70/Dockerfileanddocker/x86/Dockerfile.docker/x86/Dockerfile's stale default baselatest-x86→latest-x86-none(the actual published selfish CPU tag;latest-x86404s).if: build.branch == "main"Release & Publish trigger frompipeline.ymland deleted the now-supersededrelease-and-publish.yml. Buildkite still runs the on-hardware GPU coverage tests on pull-request branches.Tradeoff to note
The buildkite release ran on-hardware
ctest(real V100/MI210 GPUs) before pushing. GitHub Actions has no GPU runners, so release images are no longer GPU-tested at publish time — the same tradeoff already accepted for the Blackwell (sm100/sm103) targets. PR-time GPU coverage tests are unaffected and remain on buildkite.Notes
🤖 Generated with Claude Code