Skip to content

fix(agents): require full-context semantic Critic review - #184

Merged
FluffyAIcode merged 1 commit into
mainfrom
AgentMemory/full-context-critic-0717
Jul 17, 2026
Merged

fix(agents): require full-context semantic Critic review#184
FluffyAIcode merged 1 commit into
mainfrom
AgentMemory/full-context-critic-0717

Conversation

@FluffyAIcode

Copy link
Copy Markdown
Owner

Summary

  • pass the complete Generator response verbatim into the Gemma Critic
  • remove extractive evidence windows, token budgets, sampling, and summarization
  • enforce review_scope=full, equal full/context token counts, and zero omitted tokens before Critic inference
  • instruct Critic to reason over the response as one semantic argument
  • expose full review scope and context coverage in benchmark metrics/dashboard
  • extend strict allens Prefill timeout from 900 to 3600 seconds for full responses

Semantic contract

A global Critic score is forbidden unless the full Generator output is present. There is no partial-review score, chunk score, weighted score, or semantic fallback.

Performance consequence

Full-context review restores semantic coverage at the cost of cold Prefill latency on the current 16GB allens Gemma worker. Heartbeats remain visible while the strict remote job runs.

Tests

  • full-context identity and zero-omission invariants
  • strict timeout launchd configuration
  • targeted Agent GAN/launchd suite — 15 passed
  • full platform-neutral suite — 859 passed, 1 skipped
  • Python compile and diff checks pass

Made with Cursor

Pass the complete Generator response to Gemma and enforce zero omitted tokens so global Critic judgments cannot be produced from sampled or summarized evidence.

Co-authored-by: Cursor <cursoragent@cursor.com>
@cursor

cursor Bot commented Jul 17, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@FluffyAIcode
FluffyAIcode merged commit b4be50a into main Jul 17, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant