fix(agents): complete responses to EOS and ground critique - #178
Merged
Conversation
Continue Generator and Critic streams across chunk boundaries until model EOS, mark safety-limit truncation explicitly, and require the Critic to respect completion status and honest boundaries for open problems. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stop_reason, completion state, incomplete counts and stop-reason history in benchmark reports/UIRoot cause
The interactive REPL used one 64-token Generate call, so both answers ended mid-sentence. Critic had no completion metadata and interpreted the client truncation as a reasoning failure; it also lacked an epistemic rule for unsolved mathematics.
Tests
Made with Cursor