Skip to content

fix(agents): complete responses to EOS and ground critique - #178

Merged
FluffyAIcode merged 1 commit into
mainfrom
AgentMemory/agent-completion-rubric-0716
Jul 16, 2026
Merged

fix(agents): complete responses to EOS and ground critique#178
FluffyAIcode merged 1 commit into
mainfrom
AgentMemory/agent-completion-rubric-0716

Conversation

@FluffyAIcode

Copy link
Copy Markdown
Owner

Summary

  • treat 64 tokens as a streaming chunk and continue Generate calls until model EOS
  • add a separate 512-token safety cap; reaching it marks the stage incomplete and fails the Agent gate
  • persist stop_reason, completion state, incomplete counts and stop-reason history in benchmark reports/UI
  • pass Generator completion metadata to Critic
  • prohibit Critic from calling an EOS-complete answer truncated or penalizing an honest statement that an open problem has no accepted proof
  • retain explicit no-progress and server stop handling

Root cause

The interactive REPL used one 64-token Generate call, so both answers ended mid-sentence. Critic had no completion metadata and interpreted the client truncation as a reasoning failure; it also lacked an epistemic rule for unsolved mathematics.

Tests

  • chunk continuation to EOS and explicit safety-limit tests
  • incomplete stage gate and report aggregation tests
  • Critic/REPL privacy and cache gate tests
  • focused suite — 9 passed
  • full platform-neutral suite — 852 passed, 1 skipped

Made with Cursor

Continue Generator and Critic streams across chunk boundaries until model EOS, mark safety-limit truncation explicitly, and require the Critic to respect completion status and honest boundaries for open problems.

Co-authored-by: Cursor <cursoragent@cursor.com>
@cursor

cursor Bot commented Jul 16, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@FluffyAIcode
FluffyAIcode merged commit d46a598 into main Jul 16, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant