Add cancellation token to hooks and pipeline bootstrap#345
Add cancellation token to hooks and pipeline bootstrap#345
Conversation
|
I'm not sure why we need the token to track cancellation instead of just handling the exception inside the hook that stop running the hooks and scope. |
Another approach could be to add a I had a use-case for this this morning where a RabbitMQ channel closing must cancel all its yielded messages. |
I wanted to do that initial, but not running the following hooks was ok, not running the scope function was trickier. I might be because I was trying to work just in the I will the idea to handle it in the executor, I will try something. Thanks for the feedback. |
|
I have a question: |
f90856e to
a474d41
Compare
|
@isra17 ready for review |
a474d41 to
18d88aa
Compare
No description provided.