change text "handshare failure" to "handshake failure or TLS extension not supported"#18
Open
Wikinaut wants to merge 1 commit intoFiloSottile:masterfrom
Open
change text "handshare failure" to "handshake failure or TLS extension not supported"#18Wikinaut wants to merge 1 commit intoFiloSottile:masterfrom
Wikinaut wants to merge 1 commit intoFiloSottile:masterfrom
Conversation
alertHandshakeFailure: "handshake failure. This could mean that the TLS extension is not supported.", I haven't tested this code change yet, but I do see "handshake failure" for servers which do not offer TLS, so the text should inform about this possibility.
Owner
|
By TLS extension you mean TLS itself? |
Author
|
@FiloSottile when a server runs an older openssl which do not offer TLS, than your script says "handshake failure", but users then do not know whether this is a "good" or "bad" server (with respect to the Heartbleed bug). This is why I suggest to show then my proposed text. You can compare your tool against the competitive tool http://possible.lv/tools/hb/ which in such cases (no TLS implemented) says |
|
Test case: https://mozilla.org |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I do see "handshake failure" for servers which do not offer TLS, so the text should inform about this possibility.alertHandshakeFailure: "handshake failure. This could mean that the TLS extension is not supported.",
I haven't tested this code change yet.