Correct the security vulnerability language#107
Open
dprothero wants to merge 1 commit intoFalconerd:masterfrom
Open
Correct the security vulnerability language#107dprothero wants to merge 1 commit intoFalconerd:masterfrom
dprothero wants to merge 1 commit intoFalconerd:masterfrom
Conversation
The secret is used to sign the webhook so you can verify the signature to ensure you know the webhook came from GitHub. If an attacker were to learn or guess the secret, they would be able to create fake events and sign them with the same secret, so you would think they came from GitHub. They would not, however, get access to receive your webhooks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The secret is used to sign the webhook so you can verify the signature to ensure you know the webhook came from GitHub. If an attacker were to learn or guess the secret, they would be able to create fake events and sign them with the same secret, so you would think they came from GitHub. They would not, however, get access to receive your webhooks.