CI: pnpm verify on pull_request + Node 24 opt-in#3
Merged
Conversation
Adds a CI workflow running pnpm verify (typecheck + lint + format check + static-export build) on every pull request, so branches get a green/red check before merge instead of only the post-merge deploy gating. Sets FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 in both workflows ahead of the 2026-06-16 forced migration (actions/deploy-pages@v4 still declares Node 20). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
featurescript
added a commit
that referenced
this pull request
Jun 12, 2026
featurescript
added a commit
that referenced
this pull request
Jun 12, 2026
featurescript
added a commit
that referenced
this pull request
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does (plain English)
Two infrastructure items from the top of the backlog, shipped together because both touch GitHub Actions workflows:
pnpm verify(typecheck, lint, format check, full static-export build) and shows a green/red check before merge. Until now only the post-merge deploy workflow caught problems.FORCE_JAVASCRIPT_ACTIONS_TO_NODE24so any breakage shows up this week, while it is still a choice.Tier
Approval-required (CI/CD configuration,
.github/workflows/**). Run under the App Lead's direct "run through all tasks right now" directive from this session — merged once CI is green, and clearly flagged in the session report for after-the-fact review.Reversible?
Yes —
git revertfully restores the previous workflow setup. No data, no deploy-history impact.🤖 Generated with Claude Code