Skip to content

Remove master branch support#235

Open
junpataleta wants to merge 1 commit into
FMCorz:masterfrom
junpataleta:remove_master
Open

Remove master branch support#235
junpataleta wants to merge 1 commit into
FMCorz:masterfrom
junpataleta:remove_master

Conversation

@junpataleta
Copy link
Copy Markdown
Collaborator

The master branch will be removed on 12 August 2024

  • Remove from version options
  • No need to sync master with main during update.

doctor --masterbranch and other master-related settings are left untouched and can be dealt with separately.

@FMCorz
Copy link
Copy Markdown
Owner

FMCorz commented Aug 10, 2024

I don't think it's dramatic to keep the master branch compatibility in MDK, at least for a little while.

@junpataleta
Copy link
Copy Markdown
Collaborator Author

No worries. We at least need to remove the fallback logic to master as errors can be encountered when creating main instances when MDK is freshly installed. I've created #236 to address this.

@junpataleta junpataleta force-pushed the remove_master branch 2 times, most recently from 26db482 to 5085c24 Compare August 16, 2024 09:22
The `master` branch will be removed on 12 August 2024
- Remove from version list
- No need to sync `master` with `main` during update
@junpataleta
Copy link
Copy Markdown
Collaborator Author

@FMCorz, maybe it's time we say goodbye to master support in MDK? 😀

@FMCorz
Copy link
Copy Markdown
Owner

FMCorz commented Apr 16, 2025

Good idea, repos with the master branch should be fairly rare nowadays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants