Draft
Conversation
LucasMaupin
requested changes
Jun 23, 2025
Comment on lines
35
to
39
| const productionManager = new ProductionManager(dbManager); | ||
| await productionManager.load(); | ||
|
|
||
| const ingestManager = new IngestManager(dbManager); | ||
| await ingestManager.load(); |
Contributor
There was a problem hiding this comment.
Won't this call db.connect twice?
Contributor
There was a problem hiding this comment.
The dbManager should keep track whether it is connected already. Not sure this is how it is today, but how it should be.
| } | ||
| } | ||
|
|
||
| private async pollDeviceData(ingest: Ingest) { |
Contributor
There was a problem hiding this comment.
Not sure we want the backend to poll devices all the time? Why not let the frontend do the polling (when on ingest page) to the device endpoint in the manager.
Saelmala
force-pushed
the
feat-add-support-for-ingest-devices
branch
from
668ce06 to
170fbcf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the 'real' audio device type we get from PortAudio in intercom-ingest (currently a PR in intercom-ingest).