Skip to content

Head pitch slider in MediaPipeController #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PGComai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Head pitch slider in MediaPipeController #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Mods/MediaPipe/MediaPipeController.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ var _init_complete = false

var frames_missing_before_spine_reset = 6.0
var blend_to_rest_speed = 4.5
var head_pitch_offset: float = 0.0

# FIXME: Prune unused settings.

Expand Down Expand Up @@ -141,6 +142,10 @@ func _ready():
"head_rotation_smoothing", "Head Rotation Smoothing",
{ "min" : 1.0, "max" : 10.0 },
"advanced")
add_tracked_setting(
"head_pitch_offset", "Head pitch offset",
{ "min" : -1.0, "max" : 1.0 },
"advanced")


add_tracked_setting(
Expand Down Expand Up @@ -731,8 +736,11 @@ func _process(delta):
head_quat_array[1] * head_quat_multiplier[1],
head_quat_array[2] * head_quat_multiplier[2],
head_quat_array[3] * head_quat_multiplier[3])).get_euler()
var head_basis_target := Basis.from_euler(head_euler * head_rotation_scale)
# Rotating the head by the x axis to allow for pitch offset
head_basis_target = head_basis_target.rotated(head_basis_target.x, head_pitch_offset)
$Head.transform.basis = $Head.transform.basis.slerp(
Basis.from_euler(head_euler * head_rotation_scale),
head_basis_target,
delta_scale * (1.0 / head_rotation_smoothing))
else:

Expand Down