Skip to content

chore: user hint & opt download logic - #13

Merged
Tohrusky merged 6 commits into
EutropicAI:mainfrom
TohruskyDev:main
Feb 16, 2026
Merged

chore: user hint & opt download logic#13
Tohrusky merged 6 commits into
EutropicAI:mainfrom
TohruskyDev:main

Conversation

@Tohrusky

Copy link
Copy Markdown
Member

No description provided.

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @Tohrusky, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the user experience by providing clearer guidance on required configurations for image generation and optimizing model status checks. It also includes minor UI adjustments to improve the visual consistency of select menus and download progress indicators, making the application more intuitive and visually appealing.

Highlights

  • User Guidance and Validation: Refactored validation logic for image generation, providing early user hints if model or output folders are not configured, improving the initial user experience.
  • Model Status Check Optimization: Introduced a 'fastCheck' parameter to the 'checkModel' function in the store, allowing for more efficient and potentially quicker model status verification.
  • UI/UX Enhancements: Updated the UI theme for select dropdowns and refined the styling of the download progress card for better visual consistency and readability, particularly adjusting colors for contrast.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/renderer/src/App.vue
    • Adjusted the theme for the 'Select' component's internal menu, changing its background and option text colors for better contrast.
  • src/renderer/src/store/zimageStore.ts
    • Modified the 'checkModel' function to include a 'fastCheck' boolean parameter, allowing for quicker model status verification.
  • src/renderer/src/views/ZImageGenerate.vue
    • Refactored validation logic for 'canGenerate' and 'validationMessage' computed properties, moving them for better organization.
    • Added an initial warning message on component mount if essential configuration (model/output folders) is missing, guiding the user proactively.
    • Updated the styling of the download progress card, switching to an 'ios-glass-dark' class and adjusting text colors for improved visibility.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@Tohrusky
Tohrusky merged commit d312246 into EutropicAI:main Feb 16, 2026
6 checks passed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces user hints for missing configuration and refactors some logic. The changes are generally positive, improving user experience. However, I've identified a high-severity UI bug that makes text unreadable due to a style mismatch in the download modal. Additionally, there's a misleading code comment and some confusing logic in a computed property that could be simplified for better maintainability. My review includes suggestions to address these points.

<NCard
class="glass-panel"
style="width: 400px;"
class="ios-glass-dark"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Using the ios-glass-dark class here creates a dark background for the download modal. However, the text colors for the download progress information have been changed to black (in lines 808 and 814), which will result in very poor contrast and make the text unreadable. It seems the intention was to have a light-themed modal. To fix this, you should use a class that provides a light background, such as glass-panel which was used previously.

        class="glass-panel"

Comment thread src/renderer/src/App.vue
InternalSelectMenu: {
color: 'rgba(20, 20, 20, 0.9)', // Darker menu for contrast
optionTextColor: 'white',
color: 'rgba(255, 255, 255, 0.95)', // Darker menu for contrast

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment // Darker menu for contrast is no longer accurate after changing the color to rgba(255, 255, 255, 0.95), which is a very light color. Please update the comment to reflect that this is now a light menu to avoid confusion for future developers.

        color: 'rgba(255, 255, 255, 0.95)', // Light menu for contrast

Comment on lines +64 to +68
const canGenerate = computed(() => {
if (isGenerating.value)
return true // Allow stopping
return !!modelFolder.value && !!outputFolder.value
})

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The logic in canGenerate is confusing. The if (isGenerating.value) branch and the // Allow stopping comment are misleading because this computed property is only used to validate starting a generation, not stopping it. This makes the code harder to understand and maintain. For better clarity, canGenerate should only contain logic relevant to its actual use case.

const canGenerate = computed(() => {
  return !!modelFolder.value && !!outputFolder.value
})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant