build: use uv as pkg manager - #41
Conversation
Summary of ChangesHello @Tohrusky, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a significant refactoring of the project's build and dependency management infrastructure. By adopting Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request migrates the project from Poetry to uv for package management and hatch for building. The changes involve updating the pyproject.toml to the PEP 621 standard, replacing poetry commands with uv commands in the Makefile, and updating pre-commit hook versions.
The migration is a good step towards modern Python packaging. However, I've found several critical and high-severity issues in the new pyproject.toml configuration that need to be addressed:
- An incorrect PyTorch index URL is used, which will cause dependency installation to fail.
- The dependency groups are not defined using the standard
[project.optional-dependencies]table. - A non-standard
[tool.uv].default-groupskey is used. - The platform markers for PyTorch dependencies only account for Windows, which will prevent GPU-accelerated builds on Linux.
- There's also a minor issue with a redundant dependency and the use of an alpha version for a pre-commit hook.
Addressing these points will ensure the new packaging setup is correct, maintainable, and works across different platforms.
No description provided.