fix: handle multiple begin/end blocks in n8n streaming#39
Merged
Conversation
Remove premature break on 'end' chunk type to support multi-step n8n agent workflows and add error chunk handling. Co-authored-by: opencode <opencode@opencode.ai>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the n8n streaming response handling in the Home Assistant webhook_conversation integration to correctly support multi-step agent workflows (multiple begin/end blocks) and to surface n8n-streamed errors.
Changes:
- Stop treating the first
"end"chunk as terminal so streaming can continue across multiple begin/end blocks. - Add handling for
"error"chunks by raising aHomeAssistantError.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
🎉 This PR is included in version 1.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove premature break on 'end' chunk type to support multi-step n8n agent workflows and add error chunk handling.
Seems to be working as intended now on my own HASS instance. n8n structuredChunk definition can be found in: https://github.com/n8n-io/n8n/blob/bb7d137cf735bcdf65bbcf8ff58fa911d83121f5/packages/workflow/src/interfaces.ts#L3612
Fixes #38