Skip to content

ci: fix Clippy, Rustfmt, and Typos failures for Rust 1.95 stable#2115

Open
glaziermag wants to merge 1 commit into
EricLBuehler:masterfrom
glaziermag:fix/ci-upstream-breakage
Open

ci: fix Clippy, Rustfmt, and Typos failures for Rust 1.95 stable#2115
glaziermag wants to merge 1 commit into
EricLBuehler:masterfrom
glaziermag:fix/ci-upstream-breakage

Conversation

@glaziermag

@glaziermag glaziermag commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes CI failures introduced by #2109 (fast CUDA MMQ GGUF kernels) merged on 2026-04-15, combined with new lints in Rust 1.95 stable.

CI has been red on master since #2109 was merged. Every PR targeting master inherits these failures because CI merges the PR branch into current master.

Changes

Typos

  • Exclude vendored mistralrs-quant/kernels/mmq_gguf/ directory
  • Add CU_DEVICE_ATTRIBUTE_MAX_SHARED_MEMORY_PER_BLOCK_OPTIN to ignore list

Rustfmt (1.95)

  • Fix import ordering in openapi_doc.rs
  • Reformat lines affected by other lint fixes

Clippy (1.95)

  • useless_conversion: remove redundant .into_iter() in zip/extend calls across tool_dispatch, rag, llava, idefics3, gemma4, distributed/layers
  • iter_kv_map: use .into_values().flatten() in default_scheduler
  • manual_checked_ops: use .checked_div() in distributed/layers, video.rs, pyo3/util.rs
  • let_unit_value: remove unit let binding in bench.rs
  • dead_code: allow unused num_experts field in MoEExperts (set but not yet read)

Validation Result

Validation, 2026-05-14: ACTUAL, FEASIBLE_NOW.

Environment:

  • GPU validation environment
  • Rust 1.95.0 (59807616e 2026-04-14)
  • Typos 1.46.1

Base commit tested: 2d4ba4f16f61e5e18be085d0dd137bc95cba038a

cargo fmt --all -- --check
typos --config .typos.toml
cargo clippy --workspace --tests --examples -- -D warnings

Base result: all three failed. Rustfmt failed import ordering in mistralrs-server-core/src/openapi_doc.rs; typos failed on CUDA MMQ GGUF kernel terms; clippy failed two useless_conversion lints and one manual_checked_ops lint in mistralrs-quant/src/distributed/layers.rs.

PR head tested: 0a11bf2d931d76f7440c9ac24bc874fc69ba0134

Same commands all passed cleanly:

cargo fmt --all -- --check
typos --config .typos.toml
cargo clippy --workspace --tests --examples -- -D warnings

This is ACTUAL before/after validation for the Rust 1.95 CI/lint failures. GPU behavior is not material for this PR; the A100 machine was only the requested validation host.

@github-actions

github-actions Bot commented Apr 17, 2026

Copy link
Copy Markdown
Code Metrics Report
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 Language              Files        Lines         Code     Comments       Blanks
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 C Header                  5          305          210           52           43
 CSS                       2         1181         1036           34          111
 CUDA                     59        17706        13869         1637         2200
 Dockerfile                1           39           22            8            9
 HTML                      2          235          197           14           24
 JavaScript               16         3580         2702          486          392
 Jinja2                    7          694          656            5           33
 JSON                     21          409          406            0            3
 Makefile                  1            6            5            0            1
 Metal Shading Lan|       31        11647         9007         1064         1576
 PowerShell                1          300          227           30           43
 Python                  125         8316         6808          412         1096
 Shell                     2          485          329           95           61
 Plain Text                3         3723            0         2413         1310
 TOML                     27         1290         1124           35          131
 YAML                      3           25           23            2            0
─────────────────────────────────────────────────────────────────────────────────
 Jupyter Notebooks         3          122           83           23           16
 |- Markdown               1           60           30           22            8
 |- Python                 1          122          113            1            8
 (Total)                              304          226           46           32
─────────────────────────────────────────────────────────────────────────────────
 Markdown                105        11197            0         8067         3130
 |- BASH                  72          934          691          149           94
 |- Dockerfile             1            1            1            0            0
 |- JSON                  20          719          719            0            0
 |- PowerShell             3            3            3            0            0
 |- Python                23         1038          862           60          116
 |- Rust                  51         2048         1718           54          276
 |- TOML                   6          207          164            0           43
 |- YAML                   2            9            8            1            0
 (Total)                            16156         4166         8331         3659
─────────────────────────────────────────────────────────────────────────────────
 Rust                    547       236072       207590         6565        21917
 |- Markdown             361         8962          452         7385         1125
 (Total)                           245034       208042        13950        23042
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 Total                   961       311435       249055        28614        33766
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

Fixes CI failures introduced by EricLBuehler#2109 (fast CUDA MMQ GGUF kernels) merged
on 2026-04-15, combined with new lints in Rust 1.95 stable:

Typos:
- Exclude vendored mistralrs-quant/kernels/mmq_gguf/ directory
- Add CU_DEVICE_ATTRIBUTE_MAX_SHARED_MEMORY_PER_BLOCK_OPTIN to ignore

Rustfmt (1.95):
- Fix import ordering in openapi_doc.rs
- Reformat lines affected by other lint fixes

Clippy (1.95):
- useless_conversion: remove redundant .into_iter() in zip/extend calls
  across tool_dispatch, rag, llava, idefics3, gemma4, distributed/layers
- iter_kv_map: use .into_values().flatten() in default_scheduler
- manual_checked_ops: use .checked_div() in distributed/layers, video.rs,
  pyo3/util.rs
- let_unit_value: remove unit let binding in bench.rs
- dead_code: allow unused num_experts field in MoEExperts (set but unread)

Signed-off-by: glaziermag <glaziermag@users.noreply.github.com>
@glaziermag glaziermag force-pushed the fix/ci-upstream-breakage branch from e310b43 to 0a11bf2 Compare April 17, 2026 22:44
@glaziermag glaziermag changed the title ci: fix Clippy, Rustfmt, and Typos failures from #2109 ci: fix Clippy, Rustfmt, and Typos failures for Rust 1.95 stable Apr 17, 2026
@glaziermag glaziermag marked this pull request as draft May 5, 2026 19:16
@glaziermag

glaziermag commented May 18, 2026

Copy link
Copy Markdown
Contributor Author

Wave 1 evidence bundle update:

PR: #2115
Linked issue: CI failures after #2109
Base SHA: 2d4ba4f16f61e5e18be085d0dd137bc95cba038a
Current PR-head SHA: 0a11bf2d931d76f7440c9ac24bc874fc69ba0134
Fixed-head SHA, if changed: N/A

Exact commands recorded in the PR body:

cargo fmt --all -- --check
typos --config .typos.toml
cargo clippy --workspace --tests --examples -- -D warnings

Environment: GCP a2-highgpu-1g A100 host used as cloud validation host, Rust 1.95.0 (59807616e 2026-04-14), Typos 1.46.1; GPU behavior is not material.
A100 category: A100_HOST_OPTIONAL.
Base result: all three commands failed on base; rustfmt import ordering, typos CUDA MMQ GGUF kernel terms, and clippy useless_conversion / manual_checked_ops failures.
Current PR-head result: same commands passed cleanly.
Tests added/changed: lint/fmt/typos cleanup across the listed Rust files and .typos.toml.
Tests passed: fmt, typos, clippy on Rust 1.95 per PR body.
Side-effect controls: lint-only/format-only; no runtime or GPU behavior claim.
Raw logs/artifacts: PR body contains command list and pass/fail summary; no separate raw log file is attached in this comment.
Remaining risks: standalone raw command logs are still useful if reviewers require downloadable artifacts.
Can say “Fixes #issue”: yes for Rust 1.95 fmt/typos/clippy CI failures introduced after #2109.
Safe wording: “Fixes Rust 1.95 fmt/typos/clippy CI failures introduced after #2109.”
Readiness status: ready-now if PR-body log excerpts are accepted; otherwise standalone raw lint logs remain to attach.

@glaziermag glaziermag marked this pull request as ready for review May 18, 2026 23:38
@glaziermag

Copy link
Copy Markdown
Contributor Author

Marked ready for review. Validation evidence and narrowed claim wording are already attached in the PR discussion/body. This PR is ready under the scoped claim described in the PR.

Ready for maintainer review. Evidence attached shows the original/base failure and current-head pass under the scoped issue conditions. The PR may use the Fixes #... wording already present in the body.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant