Skip to content

Allow no model - #105

Draft
tsnyder0 wants to merge 41 commits into
mainfrom
allow_no_model
Draft

Allow no model#105
tsnyder0 wants to merge 41 commits into
mainfrom
allow_no_model

Conversation

@tsnyder0

@tsnyder0 tsnyder0 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Allow No Model

Note:
Rebased onto docs_typos for ease of merging documentation edits.
Separate pull request coming soon.

Description

The changes made will allow for pyfhd runs to be completed without a model. Running without a model would create dirty images without any calibration.

Motivation and Context

To run without a model, changes needed to be made to the code to allow this.

Closes #92 #93 #94 #95

Types of Changes

  • Bug Fixes
  • New Feature(s)
  • Breaking Changes
  • Documentation
  • Version Change
  • Translation from FHD
  • Build or CI Change

Changelog

New Features

Feature allows you to run with no model to bypass calibration and just create dirty images.

Test Changes

  • Any new tests added mention them here
  • Any changes to existing tests and the reasons for why they have been changed also noted.

Documentation

Information about running without a model was added to the documentation

Version

Checklist

General PR Checklist

  • I have read the contribution guide
  • Add all the above to the [Changelog]

New Features Checklist

  • New Features have all new functions documented using the numpydoc docstring format
  • Updated an existing tutorial or created a tutorial to use the new feature in the documentation
  • Have added new tests or changed existing tests to cover the new feature

Existing Tests Checklist

  • If some tests fail and they are meant to, have they been changed? if so mention the exact tests that were changed and why here
  • Have the changes to existing tests been documented either through comments, changes to the docstring in ether the test or the associated functions?

Documentation Checklist

  • The documentation is able to build successfully with any new changes and they are visible in your own build

Version Checklist

  • Updated the changelog to put all the previous unreleased changelog into a version
  • Noted dependency changes since the last version

@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.66%. Comparing base (2815ab5) to head (6d50da0).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/pyfhd/io/pyfhd_quickview.py 0.00% 18 Missing ⚠️
src/pyfhd/healpix/healpix_utils.py 0.00% 12 Missing ⚠️
src/pyfhd/pyfhd.py 0.00% 12 Missing ⚠️
src/pyfhd/beam_setup/beam_utils.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
- Coverage   39.75%   39.66%   -0.09%     
==========================================
  Files          30       30              
  Lines        5728     5748      +20     
  Branches     1064     1076      +12     
==========================================
+ Hits         2277     2280       +3     
- Misses       3141     3158      +17     
  Partials      310      310              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tsnyder0
tsnyder0 force-pushed the allow_no_model branch 2 times, most recently from 7c58a1e to 2cd2514 Compare July 15, 2026 18:17

@bhazelton bhazelton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. I ignored the changes in the docs folder as those will go in a separate PR and just focused on the code changes.

Comment thread src/pyfhd/beam_setup/beam_utils.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Model File path defaults to ./input

3 participants