Allow no model - #105
Draft
tsnyder0 wants to merge 41 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
==========================================
- Coverage 39.75% 39.66% -0.09%
==========================================
Files 30 30
Lines 5728 5748 +20
Branches 1064 1076 +12
==========================================
+ Hits 2277 2280 +3
- Misses 3141 3158 +17
Partials 310 310 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tsnyder0
force-pushed
the
allow_no_model
branch
2 times, most recently
from
July 15, 2026 18:17
7c58a1e to
2cd2514
Compare
It is set up so that not having --calibrate-checkpoint in the command line will just default to false (if left as ~ in yaml file). Having --calibrate-checkpoint will just set it to true and it finds that file without having to put in the path
… having type that is not None
for more information, see https://pre-commit.ci
bhazelton
reviewed
Jul 22, 2026
bhazelton
left a comment
Member
There was a problem hiding this comment.
This is looking good. I ignored the changes in the docs folder as those will go in a separate PR and just focused on the code changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow No Model
Note:
Rebased onto
docs_typosfor ease of merging documentation edits.Separate pull request coming soon.
Description
The changes made will allow for pyfhd runs to be completed without a model. Running without a model would create dirty images without any calibration.
Motivation and Context
To run without a model, changes needed to be made to the code to allow this.
Closes #92 #93 #94 #95
Types of Changes
Changelog
New Features
Feature allows you to run with no model to bypass calibration and just create dirty images.
Test Changes
Documentation
Information about running without a model was added to the documentation
Version
Checklist
General PR Checklist
New Features Checklist
Existing Tests Checklist
Documentation Checklist
Version Checklist